You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "gabriele renzi (JIRA)" <ji...@apache.org> on 2010/03/08 22:23:27 UTC

[jira] Created: (CASSANDRA-862) Remove FBUtlities.equals in favour of ObjectUtils.equals

Remove FBUtlities.equals in favour of ObjectUtils.equals
--------------------------------------------------------

                 Key: CASSANDRA-862
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-862
             Project: Cassandra
          Issue Type: Improvement
            Reporter: gabriele renzi


the method seems to just reimplement what is already in commons lang (and with a less smart implementation I believe), replacing references to it with ObjectUtils.equals seems reasonable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-862) Remove FBUtlities.equals in favour of ObjectUtils.equals

Posted by "gabriele renzi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gabriele renzi updated CASSANDRA-862:
-------------------------------------

    Attachment: CASSANDRA-862.patch

deleted code, changed to existing commons lang implementation

> Remove FBUtlities.equals in favour of ObjectUtils.equals
> --------------------------------------------------------
>
>                 Key: CASSANDRA-862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-862
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: gabriele renzi
>            Priority: Trivial
>         Attachments: CASSANDRA-862.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> the method seems to just reimplement what is already in commons lang (and with a less smart implementation I believe), replacing references to it with ObjectUtils.equals seems reasonable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-862) Remove FBUtlities.equals in favour of ObjectUtils.equals

Posted by "gabriele renzi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

gabriele renzi updated CASSANDRA-862:
-------------------------------------

    Priority: Trivial  (was: Major)

> Remove FBUtlities.equals in favour of ObjectUtils.equals
> --------------------------------------------------------
>
>                 Key: CASSANDRA-862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-862
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: gabriele renzi
>            Priority: Trivial
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> the method seems to just reimplement what is already in commons lang (and with a less smart implementation I believe), replacing references to it with ObjectUtils.equals seems reasonable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-862) Remove FBUtlities.equals in favour of ObjectUtils.equals

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842823#action_12842823 ] 

Gary Dusbabek commented on CASSANDRA-862:
-----------------------------------------

+1 Thanks!

> Remove FBUtlities.equals in favour of ObjectUtils.equals
> --------------------------------------------------------
>
>                 Key: CASSANDRA-862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-862
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: gabriele renzi
>            Priority: Trivial
>         Attachments: CASSANDRA-862.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> the method seems to just reimplement what is already in commons lang (and with a less smart implementation I believe), replacing references to it with ObjectUtils.equals seems reasonable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-862) Remove FBUtlities.equals in favour of ObjectUtils.equals

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843560#action_12843560 ] 

Hudson commented on CASSANDRA-862:
----------------------------------

Integrated in Cassandra #374 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/374/])
     Replace usage of FBUtilities.equals with apache-commons equivalent. Patch by Gabriele Renzi, reviewed by Gary Dusbabek.


> Remove FBUtlities.equals in favour of ObjectUtils.equals
> --------------------------------------------------------
>
>                 Key: CASSANDRA-862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-862
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: gabriele renzi
>            Priority: Trivial
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-862.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> the method seems to just reimplement what is already in commons lang (and with a less smart implementation I believe), replacing references to it with ObjectUtils.equals seems reasonable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.