You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/06/28 07:48:59 UTC

[GitHub] [calcite] NobiGo commented on a change in pull request #2444: [CALCITE-4644] Added PERCENTILE_CONT and PERCENTILE_DISC functions in…

NobiGo commented on a change in pull request #2444:
URL: https://github.com/apache/calcite/pull/2444#discussion_r659554741



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -1181,6 +1185,20 @@ public static Expression multiplyDivide(Expression e, BigDecimal multiplier,
     }
   }
 
+  /** Implementor for the {@code PERCENTILE_CONT} aggregate function. */
+  static class PercentileContImplementor extends StrictAggImplementor {

Review comment:
       If you don't plan implement Calcite's execute function. Please remove the specific implementor about PERCENTILE_CONT and PERCENTILE_DISC. This is not fully functional. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org