You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2009/07/20 18:27:45 UTC

svn commit: r795900 - in /commons/proper/math/trunk/src: java/org/apache/commons/math/fraction/BigFraction.java test/org/apache/commons/math/fraction/BigFractionTest.java

Author: luc
Date: Mon Jul 20 16:27:45 2009
New Revision: 795900

URL: http://svn.apache.org/viewvc?rev=795900&view=rev
Log:
added test for BigFraction serialization

Modified:
    commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/BigFraction.java
    commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/BigFractionTest.java

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/BigFraction.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/BigFraction.java?rev=795900&r1=795899&r2=795900&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/BigFraction.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/fraction/BigFraction.java Mon Jul 20 16:27:45 2009
@@ -31,9 +31,9 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public class BigFraction extends Number implements FieldElement<BigFraction>, Comparable<BigFraction>, Serializable {
-    // TODO: Add Serializable documentation
-    // TODO: Check Serializable implementation
+public class BigFraction
+    extends Number
+    implements FieldElement<BigFraction>, Comparable<BigFraction>, Serializable {
 
     /** A fraction representing "2 / 1". */
     public static final BigFraction TWO = new BigFraction(2);

Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/BigFractionTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/BigFractionTest.java?rev=795900&r1=795899&r2=795900&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/BigFractionTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/fraction/BigFractionTest.java Mon Jul 20 16:27:45 2009
@@ -20,6 +20,7 @@
 import java.math.BigInteger;
 
 import org.apache.commons.math.ConvergenceException;
+import org.apache.commons.math.TestUtils;
 
 import junit.framework.TestCase;
 
@@ -550,4 +551,15 @@
         assertEquals(new BigFraction(1594323, 8192), new BigFraction(2, 3).pow(BigInteger.valueOf(-13l)));
     }
 
+    public void testSerial() throws FractionConversionException {
+        BigFraction[] fractions = {
+            new BigFraction(3, 4), BigFraction.ONE, BigFraction.ZERO,
+            new BigFraction(17), new BigFraction(Math.PI, 1000),
+            new BigFraction(-5, 2)
+        };
+        for (BigFraction fraction : fractions) {
+            assertEquals(fraction, TestUtils.serializeAndRecover(fraction));
+        }
+    }
+
 }