You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by markerickson-wf <gi...@git.apache.org> on 2016/08/28 01:34:30 UTC
[GitHub] thrift pull request #1068: THRIFT-3905 Initialize bool, int, and double prop...
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1068
THRIFT-3905 Initialize bool, int, and double properties
see https://issues.apache.org/jira/browse/THRIFT-3905
@tylertreat-wf
@stevenosborne-wf
@brianshannan-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1068
----
commit b354b0541a9b4ba786ea53ba8a8f63cecd770cd9
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-08-28T01:32:13Z
THRIFT-3905 Initialize bool, int, and double properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1068: THRIFT-3905 Initialize bool, int, and double prop...
Posted by tylertreat-wf <gi...@git.apache.org>.
Github user tylertreat-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1068#discussion_r76622450
--- Diff: compiler/cpp/src/generate/t_dart_generator.cc ---
@@ -2312,6 +2313,34 @@ string t_dart_generator::type_to_enum(t_type* type) {
throw "INVALID TYPE IN type_to_enum: " + type->get_name();
}
+std::string t_dart_generator::init_value(t_type* ttype) {
+ string result = "";
+ if (ttype->is_typedef()) {
+ ttype = ((t_typedef*)ttype)->get_type();
--- End diff --
nit: indentation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1068: THRIFT-3905 Initialize bool, int, and double prop...
Posted by markerickson-wf <gi...@git.apache.org>.
Github user markerickson-wf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1068#discussion_r76627300
--- Diff: compiler/cpp/src/generate/t_dart_generator.cc ---
@@ -2312,6 +2313,34 @@ string t_dart_generator::type_to_enum(t_type* type) {
throw "INVALID TYPE IN type_to_enum: " + type->get_name();
}
+std::string t_dart_generator::init_value(t_type* ttype) {
+ string result = "";
+ if (ttype->is_typedef()) {
+ ttype = ((t_typedef*)ttype)->get_type();
--- End diff --
ugh, a tab vs space issue - thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1068: THRIFT-3905 Initialize bool, int, and double prop...
Posted by markerickson-wf <gi...@git.apache.org>.
GitHub user markerickson-wf reopened a pull request:
https://github.com/apache/thrift/pull/1068
THRIFT-3905 Initialize bool, int, and double properties
see https://issues.apache.org/jira/browse/THRIFT-3905
@tylertreat-wf
@stevenosborne-wf
@brianshannan-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1068
----
commit b354b0541a9b4ba786ea53ba8a8f63cecd770cd9
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-08-28T01:32:13Z
THRIFT-3905 Initialize bool, int, and double properties
commit 0617d33d1ff15b5425fce37f2e76971a1b8aadf7
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-08-29T17:04:40Z
Only initialize non-optional fields.
THRIFT-3905
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1068: THRIFT-3905 Initialize bool, int, and double properties
Posted by brianshannan-wf <gi...@git.apache.org>.
Github user brianshannan-wf commented on the issue:
https://github.com/apache/thrift/pull/1068
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1068: THRIFT-3905 Initialize bool, int, and double prop...
Posted by markerickson-wf <gi...@git.apache.org>.
Github user markerickson-wf closed the pull request at:
https://github.com/apache/thrift/pull/1068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1068: THRIFT-3905 Initialize bool, int, and double properties
Posted by tylertreat-wf <gi...@git.apache.org>.
Github user tylertreat-wf commented on the issue:
https://github.com/apache/thrift/pull/1068
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1068: THRIFT-3905 Initialize bool, int, and double properties
Posted by brianshannan-wf <gi...@git.apache.org>.
Github user brianshannan-wf commented on the issue:
https://github.com/apache/thrift/pull/1068
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1068: THRIFT-3905 Initialize bool, int, and double prop...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---