You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devabhishekpal (via GitHub)" <gi...@apache.org> on 2026/01/12 05:48:00 UTC

[PR] HDDS-14044. Handle nullish values for Deletion Progress in OM UI [ozone]

devabhishekpal opened a new pull request, #9625:
URL: https://github.com/apache/ozone/pull/9625

   ## What changes were proposed in this pull request?
   HDDS-14044. Handle nullish values for Deletion Progress in OM UI
   
   Please describe your PR in detail:
   * In the current OM UI the Deletion Progress details are based on the metrics. Since this takes time to initialize the UI doesn't handle the null values gracefully and instead shows NaN, null values which is not good.
   * This PR adds handling the null case and shows N/A instead to indicate that the data is not yet present.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-14044
   
   ## How was this patch tested?
   Patch was tested manually.
   Before the patch:
   <img width="3420" height="516" alt="image (19)" src="https://github.com/user-attachments/assets/3421fdbe-6039-4fd5-9255-f353af598362" />
   
   After the patch:
   <img width="1710" height="252" alt="Screenshot 2026-01-12 at 10 23 01" src="https://github.com/user-attachments/assets/44cf2b3d-7232-49d8-8e55-f2a7e1604a30" />
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14044. Handle nullish values for Deletion Progress in OM UI [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #9625:
URL: https://github.com/apache/ozone/pull/9625


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14044. Handle nullish values for Deletion Progress in OM UI [ozone]

Posted by "devabhishekpal (via GitHub)" <gi...@apache.org>.
devabhishekpal commented on code in PR #9625:
URL: https://github.com/apache/ozone/pull/9625#discussion_r2681532942


##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -118,6 +118,7 @@
             ctrl.Date = Date;
 
             ctrl.formatBytes = function(bytes, decimals) {
+               if (!bytes) return 'N/A';

Review Comment:
   Yes, thanks for catching this. 0 will also trigger this condition. Addressed in the latest commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14044. Handle nullish values for Deletion Progress in OM UI [ozone]

Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #9625:
URL: https://github.com/apache/ozone/pull/9625#discussion_r2681519161


##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -118,6 +118,7 @@
             ctrl.Date = Date;
 
             ctrl.formatBytes = function(bytes, decimals) {
+               if (!bytes) return 'N/A';

Review Comment:
   ``!bytes`` will return `true` for `0` as well I believe. Can you check once



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14044. Handle nullish values for Deletion Progress in OM UI [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9625:
URL: https://github.com/apache/ozone/pull/9625#issuecomment-3777127541

   Thanks @devabhishekpal for the patch, @ayushtkn, @priyeshkaratha for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14044. Handle nullish values for Deletion Progress in OM UI [ozone]

Posted by "devabhishekpal (via GitHub)" <gi...@apache.org>.
devabhishekpal commented on code in PR #9625:
URL: https://github.com/apache/ozone/pull/9625#discussion_r2681532942


##########
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js:
##########
@@ -118,6 +118,7 @@
             ctrl.Date = Date;
 
             ctrl.formatBytes = function(bytes, decimals) {
+               if (!bytes) return 'N/A';

Review Comment:
   Yes, thanks for catching this. 0 will also trigger this condition. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org