You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2007/08/08 09:56:34 UTC

[PATCH] Fix svn switch --relocate with --depth

Hi,

With reference to http://svn.haxx.se/dev/archive-2007-08/0082.shtml , I 
am attaching a patch along with this mail which will not allow "--depth" 
to be used along with "--relocate" in "svn switch" command.

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/

Re: [PATCH] Fix svn switch --relocate with --depth

Posted by Kamesh Jayachandran <ka...@collab.net>.
>> -        opt_state.relocate = TRUE;
>> +        if (opt_state.depth >= 0)
>>   
> +        if (opt_state.depth != svn_depth_unknown)
>
> Would be better.
>
>
> With regards
> Kamesh Jayachandran
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

Thanks Senthil, Committed the patch with tweaks at r26007.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix svn switch --relocate with --depth

Posted by Kamesh Jayachandran <ka...@collab.net>.
>                          "combination of arguments"));
> +            return svn_cmdline_handle_exit_error(err, pool, "svn: ");
> +          }
>          /* ### TODO(sd): Use svn_depth_from_word() here?  That could work
>             ### as long as that function continues to return
>             ### svn_depth_unknown for unrecognized words, but there's
> @@ -1294,7 +1301,14 @@
>          opt_state.ignore_externals = TRUE;
>          break;
>        case svn_cl__relocate_opt:
> -        opt_state.relocate = TRUE;
> +        if (opt_state.depth >= 0)
>   
+        if (opt_state.depth != svn_depth_unknown)

Would be better.


With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org