You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/16 16:48:44 UTC

[GitHub] [accumulo] Manno15 opened a new pull request, #3026: Update `waitForNextAttempt` to include Logger and description

Manno15 opened a new pull request, #3026:
URL: https://github.com/apache/accumulo/pull/3026

   Marking it as draft as I didn't have the time to fully test the formatting. I was also unsure of how detailed the descriptions should be so those could be further improved with suggestions. 
   
   
   Fixes #3007. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] Manno15 closed pull request #3026: Update `waitForNextAttempt` to include Logger and description

Posted by GitBox <gi...@apache.org>.
Manno15 closed pull request #3026: Update `waitForNextAttempt` to include Logger and description
URL: https://github.com/apache/accumulo/pull/3026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] Manno15 commented on pull request #3026: Update `waitForNextAttempt` to include Logger and description

Posted by GitBox <gi...@apache.org>.
Manno15 commented on PR #3026:
URL: https://github.com/apache/accumulo/pull/3026#issuecomment-1280013701

   Build failure seems to be related to some mocking issues my changes caused inside `ZooReaderWriterTest`. I will take a look at those next weekend unless someone wants to look at them in the meantime. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #3026: Update `waitForNextAttempt` to include Logger and description

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #3026:
URL: https://github.com/apache/accumulo/pull/3026#discussion_r997499181


##########
core/src/main/java/org/apache/accumulo/fate/util/Retry.java:
##########
@@ -176,14 +174,14 @@ public long retriesCompleted() {
     return retriesDone;
   }
 
-  public void waitForNextAttempt() throws InterruptedException {
+  public void waitForNextAttempt(Logger log, String operationDesc) throws InterruptedException {

Review Comment:
   I wonder if having the method signature as `waitForNextAttempt(Consumer<String> log, String operationDesc)` would be of use here so that way you could specify the log level. Something like: `waitForNextAttempt(log::debug, "About to retry!")` or somehow wrapping the logging of the message into a single functional variable that is passed into `waitForNextAttempt()` as its only parameter. Haven't looked into this much but just putting some ideas out in case they could lead to improvements.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] Manno15 commented on pull request #3026: Update `waitForNextAttempt` to include Logger and description

Posted by GitBox <gi...@apache.org>.
Manno15 commented on PR #3026:
URL: https://github.com/apache/accumulo/pull/3026#issuecomment-1287494285

   Closing due to #3037 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org