You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/08 18:44:24 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #232:
Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
patacongo opened a new pull request #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
URL: https://github.com/apache/incubator-nuttx/pull/232
Fix new warnings in the build test output. The warnings were were of the form "... selects ARCH_PHY_INTERRUPT which has unmet dependencies (NETDEVICES && ARCH_HAVE_PHY). This was observed on the s32k148evb:nsh configuration.
I assume that this is because of the NETDEVICES dependency. In most cases, the 'select ARCH_PHY_INTERRUPT' depended on NETDEVICES, but that was not the case for i.MX RT, S32K1xx, and Tiva. This commit adds that dependency to the select like:
select ARCH_PHY_INTERRUPT if NETDEVICES
as it is done in all other Kconfig files that select ARCH_PHY_INTERRUPT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #232: Kconfig: Fix
unmet dependencies on ARCH_PHY_INTERRUPT
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
URL: https://github.com/apache/incubator-nuttx/pull/232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #232: Kconfig: Fix
unmet dependencies on ARCH_PHY_INTERRUPT
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
URL: https://github.com/apache/incubator-nuttx/pull/232#issuecomment-583768181
It took me three commits to get this right. Please squash into one if/when you merge. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #232: Kconfig: Fix
unmet dependencies on ARCH_PHY_INTERRUPT
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
URL: https://github.com/apache/incubator-nuttx/pull/232#issuecomment-583766317
Okay, I will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #232: Kconfig:
Fix unmet dependencies on ARCH_PHY_INTERRUPT
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
URL: https://github.com/apache/incubator-nuttx/pull/232#issuecomment-583766201
Should we follow the same princple mention below:
https://github.com/apache/incubator-nuttx/pull/228
https://github.com/apache/incubator-nuttx/pull/217
It's better to move ARCH_PHY_INTERRUPT to net/Kconfig just after config "ARCH_HAVE_PHY" and remove if NETDEVICES from all other Kconfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #232: Kconfig: Fix
unmet dependencies on ARCH_PHY_INTERRUPT
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #232: Kconfig: Fix unmet dependencies on ARCH_PHY_INTERRUPT
URL: https://github.com/apache/incubator-nuttx/pull/232#issuecomment-583766888
This, however, is not an ARCH_HAVE_* configuration. This actually enables functionality, it does not just indicate feature support. However, I see one case (Tiva) where the device has an internal PHY and so does not select ARCH_HAVE_PHY but does select ARCH_HAVE_PHY_INTERRUPT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services