You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 17:18:06 UTC
[GitHub] [flink] rmetzger opened a new pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
rmetzger opened a new pull request #13691:
URL: https://github.com/apache/flink/pull/13691
## What is the purpose of the change
We used to have an increased session and connection timeout configured for TravisCI.
On Azure, the environment variable we used for checking if we are in an CI environment doesn't exist anymore.
This change enables the increased timeout on Azure as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13691:
URL: https://github.com/apache/flink/pull/13691#issuecomment-712336631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4312bb06c5db6171508223cae056d5e29b258f8e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7879",
"triggerID" : "4312bb06c5db6171508223cae056d5e29b258f8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4312bb06c5db6171508223cae056d5e29b258f8e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7879)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13691:
URL: https://github.com/apache/flink/pull/13691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13691:
URL: https://github.com/apache/flink/pull/13691#issuecomment-712336631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4312bb06c5db6171508223cae056d5e29b258f8e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4312bb06c5db6171508223cae056d5e29b258f8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4312bb06c5db6171508223cae056d5e29b258f8e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13691:
URL: https://github.com/apache/flink/pull/13691#issuecomment-712336631
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4312bb06c5db6171508223cae056d5e29b258f8e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7879",
"triggerID" : "4312bb06c5db6171508223cae056d5e29b258f8e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4312bb06c5db6171508223cae056d5e29b258f8e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7879)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13691:
URL: https://github.com/apache/flink/pull/13691#discussion_r508462279
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/ZooKeeperTestUtils.java
##########
@@ -68,8 +73,9 @@ public static Configuration configureZooKeeperHA(
config.setString(HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM, zooKeeperQuorum);
int connTimeout = 5000;
- if (System.getenv().containsKey("CI")) {
+ if (System.getenv().containsKey("CI") || System.getenv().containsKey("TF_BUILD")) {
Review comment:
maybe introduce `runsOnCIInfrastructure()` to give this expression a more expressive name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13691:
URL: https://github.com/apache/flink/pull/13691#issuecomment-712843321
Thank you both for the review!
I appreciate Till's feedback on the better name, and I'll do this in the future, but I'm merging this now as-is for the sake of my efficiency ☮️ .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13691:
URL: https://github.com/apache/flink/pull/13691#issuecomment-712312334
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4312bb06c5db6171508223cae056d5e29b258f8e (Mon Oct 19 17:21:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #13691: [FLINK-19458] Fix ZK-related CI instabilities
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13691:
URL: https://github.com/apache/flink/pull/13691#discussion_r508373318
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/ZooKeeperTestUtils.java
##########
@@ -68,8 +73,9 @@ public static Configuration configureZooKeeperHA(
config.setString(HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM, zooKeeperQuorum);
int connTimeout = 5000;
- if (System.getenv().containsKey("CI")) {
+ if (System.getenv().containsKey("CI") || System.getenv().containsKey("TF_BUILD")) {
Review comment:
A `git grep "\"CI\""` didn't reveal any other code locations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org