You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/03 13:42:36 UTC

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #110: fix apache apisix icon not show issue

juzhiyuan commented on a change in pull request #110: fix apache apisix icon not show issue
URL: https://github.com/apache/incubator-apisix-dashboard/pull/110#discussion_r362812355
 
 

 ##########
 File path: src/layout/components/Sidebar/SidebarLogo.vue
 ##########
 @@ -69,6 +69,29 @@ export default class extends Vue {
   @Prop({ required: true }) private collapse!: boolean
 
   private title = 'APISIX'
+
+  get getIco() {
 
 Review comment:
   We could use an elegant way to fix this issue... Let me check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services