You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/11 10:26:39 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5274: Gradle options UI cleanup (Execution and Appearance panel).
mbien opened a new pull request, #5274:
URL: https://github.com/apache/netbeans/pull/5274
- consistent gaps and component anchors
- moved a few options to the global exec group
please note that the before screenshots are actually NB 16 and not master. So they have 1-2 fields less.
before (checkboxes in upper panel are all over the place + panel gaps + some exec options not in the lower panel):
after:
before (left gaps on checkboxes):
after:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379366976
I only wanted to fix some layout issues in the UI, consistent gaps, resizing etc, Moving things around to entirely different option panels would be more than just layout adjustments and something for another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379999400
@lkishalmi updated the `after` image on the PR with the latest change.
- added Maven card as suggested and moved the "Prefer Maven" checkbox over
- kept the left aligned checkboxes of the screenshot above
- some more tweaking for gap consistency between all cards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379347668
Well, I actually like the first new version. The second one looks too much for me.
I'd offer a third option then. Let's create a `Maven` specific panel and put that option there.
There might be other new options in that area...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] swpalmer commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
swpalmer commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379361487
The prefer Maven over Gradle option really isn't an option of Maven or Gradle. It needs to be in a more general location, possibly on the general tab, even though (currently) these are Java-related. Theoretically Gradle projects can support C++ as well so if that was ever pursued things could get messier still.
Also the tab order is a little odd, Ant, Gradle, and Maven are related build systems, they should be grouped together in the tab order. I'm not sure if that is easy to do or if the order is somewhat ad-hoc because everything is a plugin or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379350402
another proposal (all checkboxes aligned in left column):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
mbien merged PR #5274:
URL: https://github.com/apache/netbeans/pull/5274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379326713
@lkishalmi tbh I don't quite like how this looks. Can I wrap this into an "Other Options" panel?
other options panel:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5274: Gradle options UI cleanup (Execution and Appearance panel).
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5274:
URL: https://github.com/apache/netbeans/pull/5274#issuecomment-1379605963
@swpalmer That would be a major re-arch. We should create a Build Tools section in the Options Dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists