You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/08 21:28:00 UTC

[GitHub] [kafka] ableegoldman commented on pull request #8632: KAFKA-9972: Only commit tasks with valid states

ableegoldman commented on pull request #8632:
URL: https://github.com/apache/kafka/pull/8632#issuecomment-626028839


   What about all the other times we commit tasks in TaskManager? Aren't we still vulnerable to committing a CREATED task during `handleAssignment`, for example? Imho it makes sense to push this logic into the StreamTask/StandbyTask rather than chase down all code paths that may commit and make sure we are passing in only "valid" tasks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org