[GitHub] [ozone] ChenSammi commented on a change in pull request #3000: HDDS-6203. CleanUp incomplete gz files during Container move

[GitBox <gi...@apache.org>]

ChenSammi commented on a change in pull request #3000:
URL: https://github.com/apache/ozone/pull/3000#discussion_r788291861



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/GrpcReplicationClient.java
##########
@@ -161,6 +161,9 @@ public void onNext(CopyContainerResponseProto chunk) {
       try {
         chunk.getData().writeTo(stream);
       } catch (IOException e) {
+        LOG.error("Failed to write the stream buffer to {} for container {}",
+            outputPath, containerId, e);
+        deleteOutputOnFailure();

Review comment:
       stream.close();  should be called together with deleteOutputOnFailure();




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org