You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2017/03/01 12:36:22 UTC
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/
-----------------------------------------------------------
(Updated March 1, 2017, 12:36 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
Changes
-------
updating patch to fix overlooked scenarios.
Bugs: AMBARI-20208
https://issues.apache.org/jira/browse/AMBARI-20208
Repository: ambari
Description
-------
Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 6f3dfa7
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee
Diff: https://reviews.apache.org/r/57139/diff/2/
Changes: https://reviews.apache.org/r/57139/diff/1-2/
Testing
-------
Verified dependency of : listeners propert for following cases:
1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
Thanks,
Vishal Suvagia
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167272
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 12:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
>
>
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 6f3dfa7
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee
>
>
> Diff: https://reviews.apache.org/r/57139/diff/2/
>
>
> Testing
> -------
>
> Verified dependency of : listeners propert for following cases:
>
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
>
> 2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
>
> 3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
>
> 4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167711
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 2, 2017, 10:52 a.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
>
>
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3
>
>
> Diff: https://reviews.apache.org/r/57139/diff/3/
>
>
> Testing
> -------
>
> Verified dependency of : listeners propert for following cases:
>
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
>
> 2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
>
> 3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
>
> 4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167793
-----------------------------------------------------------
Ship it!
Ship It!
- Sriharsha Chintalapani
On March 2, 2017, 10:52 a.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
>
>
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3
>
>
> Diff: https://reviews.apache.org/r/57139/diff/3/
>
>
> Testing
> -------
>
> Verified dependency of : listeners propert for following cases:
>
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
>
> 2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
>
> 3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
>
> 4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/
-----------------------------------------------------------
(Updated March 2, 2017, 10:52 a.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
Changes
-------
Updating code to remove leading and trailing whitespaces, adding testcases to cover sasl scenario.
Bugs: AMBARI-20208
https://issues.apache.org/jira/browse/AMBARI-20208
Repository: ambari
Description
-------
Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3
Diff: https://reviews.apache.org/r/57139/diff/3/
Changes: https://reviews.apache.org/r/57139/diff/2-3/
Testing
-------
Verified dependency of : listeners propert for following cases:
1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
Thanks,
Vishal Suvagia
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167538
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Lines 603 (patched)
<https://reviews.apache.org/r/57139/#comment239421>
Also remove any leading or trailing whitespace
- Alejandro Fernandez
On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 12:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
>
>
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 6f3dfa7
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee
>
>
> Diff: https://reviews.apache.org/r/57139/diff/2/
>
>
> Testing
> -------
>
> Verified dependency of : listeners propert for following cases:
>
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
>
> 2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
>
> 3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
>
> 4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be
configured using kafka listeners.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57139/#review167513
-----------------------------------------------------------
Ship it!
This looks good. I suggest you to add one more test or test manually if the protocol is SASL_PLAINTEXT. As per the code it looks like handling it but good to test this part.
- Sriharsha Chintalapani
On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57139/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 12:36 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Sumit Mohanty, and Sriharsha Chintalapani.
>
>
> Bugs: AMBARI-20208
> https://issues.apache.org/jira/browse/AMBARI-20208
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adding dependency of kafka broker's listeners config to populate accurate port for Atlas atlas.kafka.bootstrap.servers property.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml 15cc73b
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 6f3dfa7
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee
>
>
> Diff: https://reviews.apache.org/r/57139/diff/2/
>
>
> Testing
> -------
>
> Verified dependency of : listeners propert for following cases:
>
> 1) Simple environment with listener's value as : PLAINTEXT://localhost:<port>
>
> 2) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>
>
> 3) Kerberos environment with listener's value as : PLAINTEXTSASL://localhost:<different_port>,PLAINTEXT://localhost:<port>
>
> 4) Kerberos environment with listener's value as : PLAINTEXT://localhost:<port> :: in this case it will pickup the port given for PLAINTEXT protocol only (as SASL port is not specified).
>
>
> Thanks,
>
> Vishal Suvagia
>
>