You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2019/01/18 18:18:05 UTC

Re: Review Request 69076: SENTRY-2301: Log where sentry stands in the snapshot fetching process, periodically

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69076/
-----------------------------------------------------------

(Updated Jan. 18, 2019, 6:18 p.m.)


Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.


Changes
-------

New patch


Repository: sentry


Description
-------

When sentry is fetching snapshot from HMS, it should log periodically on where it stands in the snapshot process. This will help person debugging it and help him understand the progress.

 

This is important as this process could take magnitude of minutes when the HMS data is huge.


Diffs (updated)
-----

  sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java 534bb51c1 
  sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java 4ff3dc91a 
  sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java 4baeb6725 


Diff: https://reviews.apache.org/r/69076/diff/3/

Changes: https://reviews.apache.org/r/69076/diff/2-3/


Testing
-------


Thanks,

Arjun Mishra