You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/25 15:08:00 UTC

[jira] [Closed] (ARROW-4798) [C++] Re-enable runtime/references cpplint check

     [ https://issues.apache.org/jira/browse/ARROW-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney closed ARROW-4798.
-------------------------------
    Fix Version/s:     (was: 2.0.0)
       Resolution: Won't Fix

The benchmark thing is enough of a nuisance that I won't bother with this. We've been pretty effective about catching mutable references in code reviews

> [C++] Re-enable runtime/references cpplint check
> ------------------------------------------------
>
>                 Key: ARROW-4798
>                 URL: https://issues.apache.org/jira/browse/ARROW-4798
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>
> This will help keep the codebase clean.
> We might consider defining some custom filters for cpplint warnings we want to suppress, like it doesn't like {{benchmark::State&}} because of the non-const reference



--
This message was sent by Atlassian Jira
(v8.3.4#803005)