You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@apache.org> on 2017/12/01 21:54:06 UTC
Re: Review Request 63765: Fixed an issue with the scheduler driver
subscribe backoff time.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review191665
-----------------------------------------------------------
src/tests/scheduler_driver_tests.cpp
Lines 107 (patched)
<https://reviews.apache.org/r/63765/#comment269506>
s/enqueue/enqueued/
sorry my bad for the typo in the comment.
- Vinod Kone
On Nov. 18, 2017, 9:32 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63765/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2017, 9:32 p.m.)
>
>
> Review request for mesos, Gilbert Song and Vinod Kone.
>
>
> Bugs: MESOS-8171
> https://issues.apache.org/jira/browse/MESOS-8171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When framework failover time is set to zero (which is the
> default value), the scheduler driver subscribe backoff time
> will also become zero. Ignore failover time if it is zero
> when deciding the subscribe backoff time.
> Also added a dedicated test.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8
> src/tests/scheduler_driver_tests.cpp 14d872b8fadfd4ef16d8923fb0df924331534bc3
>
>
> Diff: https://reviews.apache.org/r/63765/diff/2/
>
>
> Testing
> -------
>
> make check, and the new dedicated test.
>
>
> Thanks,
>
> Meng Zhu
>
>