[GitHub] [spark] mridulm commented on a diff in pull request #43095: [SPARK-44895][CORE][UI] Add 'daemon', 'priority' for ThreadStackTrace

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #43095:
URL: https://github.com/apache/spark/pull/43095#discussion_r1337963389


##########
core/src/main/scala/org/apache/spark/status/api/v1/api.scala:
##########
@@ -540,19 +540,21 @@ case class ThreadStackTrace(
     lockName: Option[String],
     lockOwnerName: Option[String],
     suspended: Boolean,
-    inNative: Boolean) {
+    inNative: Boolean,
+    isDaemon: Boolean,
+    priority: Int) {

Review Comment:
   Yeah, practically it does not convey much given how jvm and linux use thread priority in case of java.
   Wondering if it might be distracting for users - they cant really do much about it, while it ends up being a red herring while analyzing performance.
   
   I would be fine with dropping it, given the marginal value (if any) they bring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org