You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/27 06:58:23 UTC
[GitHub] [pulsar] wuxuanqicn opened a new pull request, #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
wuxuanqicn opened a new pull request, #14720:
URL: https://github.com/apache/pulsar/pull/14720
Fixes #9919
### Motivation
we need make sure broker executed all ack command and updated metrics, then we can generate and check metric
### Modifications
- enable AckReceipt
- await until ack procedure complete(ACK and ACK_RESPONSE command)
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
Need to update docs?
- [x] `no-need-doc`
(Please explain why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
URL: https://github.com/apache/pulsar/pull/14720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #14720:
URL: https://github.com/apache/pulsar/pull/14720#issuecomment-1110867316
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #14720:
URL: https://github.com/apache/pulsar/pull/14720#discussion_r853986814
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java:
##########
@@ -22,10 +22,17 @@
import org.apache.bookkeeper.client.PulsarMockLedgerHandle;
import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest;
import org.apache.pulsar.broker.stats.metrics.ManagedCursorMetrics;
-import org.apache.pulsar.client.api.Consumer;
-import org.apache.pulsar.client.api.Producer;
+
Review Comment:
The code style used in Pulsar code base doesn't have empty line between imports. you might want to configure IntelliJ to use the Pulsar code style and checkstyle configuration. the instructions are in the README, https://github.com/apache/pulsar#configure-code-style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #14720:
URL: https://github.com/apache/pulsar/pull/14720#issuecomment-1103785433
LGTM. Please rebase the changes so that this can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wuxuanqicn commented on a diff in pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
wuxuanqicn commented on code in PR #14720:
URL: https://github.com/apache/pulsar/pull/14720#discussion_r855766591
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java:
##########
@@ -22,10 +22,17 @@
import org.apache.bookkeeper.client.PulsarMockLedgerHandle;
import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest;
import org.apache.pulsar.broker.stats.metrics.ManagedCursorMetrics;
-import org.apache.pulsar.client.api.Consumer;
-import org.apache.pulsar.client.api.Producer;
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #14720:
URL: https://github.com/apache/pulsar/pull/14720#issuecomment-1110616884
closing and reopening to trigger a new build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #14720: [fix][test]: fix flaky test of ManagedCursorMetricsTest.testManagedCursorMetrics (#9919)
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #14720:
URL: https://github.com/apache/pulsar/pull/14720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org