You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Kriskras99 (via GitHub)" <gi...@apache.org> on 2025/12/18 10:33:49 UTC
[PR] feat: Configure Clippy in the workspace instead of the CI [avro-rs]
Kriskras99 opened a new pull request, #369:
URL: https://github.com/apache/avro-rs/pull/369
This way developers can run Clippy locally and get the same errors as on the CI. They've been configured as warnings, to ease development, and will only be errors in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Configure Clippy in the workspace instead of the CI [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 commented on code in PR #369:
URL: https://github.com/apache/avro-rs/pull/369#discussion_r2630779059
##########
Cargo.toml:
##########
@@ -49,3 +49,7 @@ pretty_assertions = { default-features = false, version = "1.4.1", features = ["
[profile.release.package.hello-wasm]
# Tell `rustc` to optimize for small code size.
opt-level = "s"
+
+[workspace.lints]
+# By setting the priority to -1, this lint group can be overridden for specific lints
+clippy.all = { level = "warn", priority = -1 }
Review Comment:
That's a rustc lint. And it's warn by default, so -Dwarnings will also make it an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Configure Clippy in the workspace instead of the CI [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 merged PR #369:
URL: https://github.com/apache/avro-rs/pull/369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Configure Clippy in the workspace instead of the CI [avro-rs]
Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 commented on code in PR #369:
URL: https://github.com/apache/avro-rs/pull/369#discussion_r2630777150
##########
.github/workflows/test-lang-rust-clippy.yml:
##########
@@ -47,4 +47,4 @@ jobs:
with:
toolchain: ${{ matrix.rust }}
components: clippy
- - run: cargo clippy --all-features --all-targets -- -Dclippy::all -Dunused_imports
+ - run: cargo clippy --all-features --all-targets -- -Dwarnings
Review Comment:
You're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Configure Clippy in the workspace instead of the CI [avro-rs]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #369:
URL: https://github.com/apache/avro-rs/pull/369#discussion_r2630689484
##########
.github/workflows/test-lang-rust-clippy.yml:
##########
@@ -47,4 +47,4 @@ jobs:
with:
toolchain: ${{ matrix.rust }}
components: clippy
- - run: cargo clippy --all-features --all-targets -- -Dclippy::all -Dunused_imports
+ - run: cargo clippy --all-features --all-targets -- -Dwarnings
Review Comment:
Isn't `-Dwarnings` already enabled by https://github.com/apache/avro-rs/pull/369/changes#diff-0cd900b9eb208b7d935ea9244ef166db0ab25677400847e279dd58ad7c1aec83R30 ?
##########
Cargo.toml:
##########
@@ -49,3 +49,7 @@ pretty_assertions = { default-features = false, version = "1.4.1", features = ["
[profile.release.package.hello-wasm]
# Tell `rustc` to optimize for small code size.
opt-level = "s"
+
+[workspace.lints]
+# By setting the priority to -1, this lint group can be overridden for specific lints
+clippy.all = { level = "warn", priority = -1 }
Review Comment:
What happened with `-Dunused_imports` ?!
I see no entry for it at https://rust-lang.github.io/rust-clippy/master/index.html but Google returns results for such lint ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org