You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2017/04/24 20:11:20 UTC

[GitHub] incubator-quickstep issue #240: Fix the issues with the common subexpression...

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/240
  
    @jianqiao We missed the following comments in this PR:
    
    * [Remove unused `moveTypedValue` method in `types/containers/ColumnVector.hpp`](https://github.com/apache/incubator-quickstep/pull/237#discussion_r112827764)
    * [Change `hash_cache_` as a `std::uint64_t`, instead of a smart pointer](https://github.com/apache/incubator-quickstep/pull/237#discussion_r112828399)
    * [`override` destructor needed for `CommonSubexpression`](https://github.com/apache/incubator-quickstep/pull/237#discussion_r112847577)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---