You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/09/07 13:02:32 UTC
[GitHub] [accumulo] EdColeman commented on a diff in pull request #3745: Add Separate Logger for File deletion actions in GCRun
EdColeman commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1318570726
##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -97,7 +98,8 @@ public class GCRun implements GarbageCollectionEnvironment {
private long errors = 0;
public GCRun(Ample.DataLevel level, ServerContext context) {
- this.log = LoggerFactory.getLogger(level.name() + GCRun.class);
+ this.log = LoggerFactory.getLogger(GCRun.class.getName() + level.name());
Review Comment:
Would using a dot separator between the level and the class name make sense? Would that benefit changing the order so that it was `LEVEL.GCRun`?
```suggestion
this.log = LoggerFactory.getLogger(level.name() + '.' + GCRun.class.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org