You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/04 17:52:14 UTC
[GitHub] [helix] NealSun96 commented on a change in pull request #1056: Task delay metrics endpoints on TaskDriver
NealSun96 commented on a change in pull request #1056:
URL: https://github.com/apache/helix/pull/1056#discussion_r435441124
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/JobMonitor.java
##########
@@ -41,6 +45,12 @@
private static final Logger LOG = LoggerFactory.getLogger(JobMonitor.class);
private static final long DEFAULT_RESET_INTERVAL_MS = 60 * 60 * 1000; // 1 hour
+ // The root path of ZNodes that are used to sync certain metrics to ZooKeeper. This path is the
+ // first level, and its children nodes will represent each job type. Since the metrics are
+ // aggregated by job types, the metric values will be recorded in each ZNode belonging to a job
+ // type as simple fields.
+ private static final String SYNC_ZK_ROOT_PATH = "/JOB_MONITOR_METRICS";
Review comment:
Right now the metrics are emitted by the controller. We want to expose the metrics to the client side, therefore ZNodes are used as a medium to store the metrics for access.
MBean is still used; the ZNodes are for "syncing" or "copying" the metrics to client side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org