You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ra...@apache.org on 2017/02/16 07:00:43 UTC

[2/2] git commit: updated refs/heads/master to c3c9b8f

Merge pull request #1747 from nvazquez/storageTags

CLOUDSTACK-9574: Redesign storage views## Part 1: Redesign storage tags
### Actual behavior

Primary storage tags are being saved as an entry on `storage_pool_details` with:
* name = TAG_NAME
* value = "true"

When a boolean property is defined in {{storage_pool_details}} and has value = "true", it is displayed as a tag.

![](https://issues.apache.org/jira/secure/attachment/12836196/PS-DETAILS.PNG "Screenshot 1 - Primary storage details")
![](https://issues.apache.org/jira/secure/attachment/12836195/PS.PNG "Screenshot 2 - Primary storage view")

### Goal

Redesign `Storage Tags` for Primary Storage view, to list only tags, as it is done in Host Tags (Hosts view).

## Part 2: Remove details from listImageStores API call response and UI

### Description
In Secondary Storage view we propose removing `Details` field, as `Setting` tab list details for a given image store. We also remove details from response on `listImageStores` API method

* pr/1747:
  CLOUDSTACK-9574: Redesign storage tags and remove details from listImageStores response and UI

Signed-off-by: Rajani Karuturi <ra...@accelerite.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/c3c9b8f3
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/c3c9b8f3
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/c3c9b8f3

Branch: refs/heads/master
Commit: c3c9b8f38b005309d1e5aeee8575570ee0569522
Parents: c09a9f3 13ccbda
Author: Rajani Karuturi <ra...@accelerite.com>
Authored: Thu Feb 16 12:30:15 2017 +0530
Committer: Rajani Karuturi <ra...@accelerite.com>
Committed: Thu Feb 16 12:30:15 2017 +0530

----------------------------------------------------------------------
 .../api/response/ImageStoreResponse.java        | 20 -----
 .../spring-engine-schema-core-daos-context.xml  |  1 +
 .../src/com/cloud/storage/StoragePoolTagVO.java | 64 ++++++++++++++++
 .../cloud/storage/dao/StoragePoolTagsDao.java   | 30 ++++++++
 .../storage/dao/StoragePoolTagsDaoImpl.java     | 80 +++++++++++++++++++
 .../api/query/dao/ImageStoreJoinDaoImpl.java    | 22 ------
 .../cloud/api/query/vo/ImageStoreJoinVO.java    | 14 ----
 .../com/cloud/storage/StorageManagerImpl.java   | 49 ++----------
 setup/db/db/schema-4920to41000.sql              | 81 ++++++++++++++++++++
 ui/scripts/system.js                            | 15 ----
 10 files changed, 264 insertions(+), 112 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/c3c9b8f3/server/src/com/cloud/storage/StorageManagerImpl.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/c3c9b8f3/setup/db/db/schema-4920to41000.sql
----------------------------------------------------------------------