You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "sxllwx (GitHub)" <gi...@apache.org> on 2019/11/13 12:00:26 UTC
[GitHub] [dubbo-go] sxllwx opened pull request #254: Ftr: kubernetes
for registry
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Ftr: kubernetes for registry
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
temporary lack of unit testing
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/254 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #254: Ftr:
kubernetes for registry
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
add a init len param for make-map. maybe '8' is properly.
[ Full content available at: https://github.com/apache/dubbo-go/pull/254 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #254: Ftr:
kubernetes for registry
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=h1) Report
> Merging [#254](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/8f2c625480a37aa8bd5bb65191542e499ab1d33a?src=pr&el=desc) will **decrease** coverage by `5.63%`.
> The diff coverage is `8.99%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #254 +/- ##
===========================================
- Coverage 65.15% 59.52% -5.64%
===========================================
Files 105 111 +6
Lines 6796 7552 +756
===========================================
+ Hits 4428 4495 +67
- Misses 1923 2608 +685
- Partials 445 449 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `57.8% <ø> (ø)` | :arrow_up: |
| [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `80% <ø> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <ø> (ø)` | :arrow_up: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `61.78% <ø> (ø)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <ø> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <ø> (ø)` | :arrow_up: |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `0% <0%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `0% <0%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `0% <0%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/254/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=footer). Last update [8f2c625...3455613](https://codecov.io/gh/apache/dubbo-go/pull/254?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/254 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx closed pull request #254: [WIP] kubernetes
as registry
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
[ pull request closed by sxllwx ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/254 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org