You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 11:25:39 UTC
[GitHub] [spark] cloud-fan opened a new pull request #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
cloud-fan opened a new pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The query plan of Spark SQL is a mutually recursive structure: QueryPlan -> Expression (PlanExpression) -> QueryPlan, but the transformations do not take this into account.
This PR refines the comments of `QueryPlan` to highlight this fact.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
better document.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605109517
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604950848
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399265273
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,16 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the query plan is a mutually recursive structure:
+ * QueryPlan -> Expression (subquery) -> QueryPlan
+ * The tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
Review comment:
Can we clarify which APIs can go through query plans inside subqueries too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604977895
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605109527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120490/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28050: [MINOR][DOC] Refine
comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604977468
**[Test build #120490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120490/testReport)** for PR 28050 at commit [`b340493`](https://github.com/apache/spark/commit/b340493e5a4257b58b2d4ce694ce86c72ccf2e2b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28050: [MINOR][DOC] Refine
comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604950095
**[Test build #120486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120486/testReport)** for PR 28050 at commit [`75bd849`](https://github.com/apache/spark/commit/75bd849c4f9663c6bdd330aa5cc616551eaedb41).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399278879
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,16 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the query plan is a mutually recursive structure:
+ * QueryPlan -> Expression (subquery) -> QueryPlan
+ * The tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
Review comment:
`transformExpressions` is not a traverse API as it only touches the current node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28050: [MINOR][DOC] Refine
comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605089540
**[Test build #120486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120486/testReport)** for PR 28050 at commit [`75bd849`](https://github.com/apache/spark/commit/75bd849c4f9663c6bdd330aa5cc616551eaedb41).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605090622
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399265273
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,16 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the query plan is a mutually recursive structure:
+ * QueryPlan -> Expression (subquery) -> QueryPlan
+ * The tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
Review comment:
Can we clarify which APIs can go through query plans inside subqueries too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399215147
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,14 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
+ * inherited from `TreeNode`, do not traverse into query plans inside subqueries.
Review comment:
well written. nit: How about adding the example here of the description, `QueryPlan -> Expression (PlanExpression) -> QueryPlan`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604977895
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605109527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120490/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28050: [MINOR][DOC] Refine
comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604949343
@hvanhovell @maropu @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604977900
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25195/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28050: [MINOR][DOC] Refine
comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605108992
**[Test build #120490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120490/testReport)** for PR 28050 at commit [`b340493`](https://github.com/apache/spark/commit/b340493e5a4257b58b2d4ce694ce86c72ccf2e2b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399269525
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,16 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the query plan is a mutually recursive structure:
+ * QueryPlan -> Expression (subquery) -> QueryPlan
+ * The tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
Review comment:
@cloud-fan, does this mean all the APIs under `QueryPlan` and its downstream can go through query plans inside subqueries? It sounds like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605090630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120486/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399271522
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,16 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the query plan is a mutually recursive structure:
+ * QueryPlan -> Expression (subquery) -> QueryPlan
+ * The tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
Review comment:
Okay, I just read the doc on each method you added. Should we mention what can go through and what can't?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605090630
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120486/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604950855
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25191/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605109517
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604950095
**[Test build #120486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120486/testReport)** for PR 28050 at commit [`75bd849`](https://github.com/apache/spark/commit/75bd849c4f9663c6bdd330aa5cc616551eaedb41).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604950855
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25191/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604977900
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25195/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-605090622
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604950848
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28050:
[MINOR][DOC] Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#discussion_r399278408
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -23,6 +23,16 @@ import org.apache.spark.sql.catalyst.trees.{CurrentOrigin, TreeNode, TreeNodeTag
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StructType}
+/**
+ * An abstraction of the Spark SQL query plan tree, which can be logical or physical. This class
+ * defines some basic properties of a query plan node, as well as some new transform APIs to
+ * transform the expressions of the plan node.
+ *
+ * Note that, the query plan is a mutually recursive structure:
+ * QueryPlan -> Expression (subquery) -> QueryPlan
+ * The tree traverse APIs like `transform`, `foreach`, `collect`, etc. that are
Review comment:
Only the `collectInPlanAndSubqueries` can go through subqueries, and it's documented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28050: [MINOR][DOC]
Refine comments of QueryPlan regarding subquery
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28050: [MINOR][DOC] Refine comments of QueryPlan regarding subquery
URL: https://github.com/apache/spark/pull/28050#issuecomment-604977468
**[Test build #120490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120490/testReport)** for PR 28050 at commit [`b340493`](https://github.com/apache/spark/commit/b340493e5a4257b58b2d4ce694ce86c72ccf2e2b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org