[GitHub] [hudi] danny0405 commented on a change in pull request #3787: [HUDI-2548] Flink streaming reader misses the rolling over file handles

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #3787:
URL: https://github.com/apache/hudi/pull/3787#discussion_r728599250



##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java
##########
@@ -139,7 +139,7 @@ public void processElement(I value, ProcessFunction<I, Object>.Context ctx, Coll
   public void close() {
     if (this.writeClient != null) {
       this.writeClient.cleanHandlesGracefully();
-      this.writeClient.close();
+      // this.writeClient.close();

Review comment:
       Because the embedded timeline server is JVM process singleton, if one thread starts to close the server, the other threads that needs the server would fall into exception.
   
   Would fix the server as a driver service in following PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org