[incubator-plc4x] branch master updated: use java8 streams api for closing of handles

[sr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new 3b6460b  use java8 streams api for closing of handles
3b6460b is described below

commit 3b6460b8231fd32c0c5aa7b9b85c9bf1b810e652
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri May 18 09:20:50 2018 +0200

    use java8 streams api for closing of handles
---
 .../plc4x/java/ads/connection/AdsAbstractPlcConnection.java    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
index 6dd01bb..e16fdc0 100644
--- a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
+++ b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
@@ -191,8 +191,8 @@ public abstract class AdsAbstractPlcConnection extends AbstractPlcConnection imp
 
     @Override
     public void close() {
-        for (AdsAddress adsAddress : addressMapping.values()) {
-            AdsWriteRequest adsWriteRequest = AdsWriteRequest.of(
+        addressMapping.values().stream()
+            .map(adsAddress -> AdsWriteRequest.of(
                 targetAmsNetId,
                 targetAmsPort,
                 sourceAmsNetId,
@@ -201,10 +201,10 @@ public abstract class AdsAbstractPlcConnection extends AbstractPlcConnection imp
                 IndexGroup.ReservedGroups.ADSIGRP_SYM_RELEASEHND,
                 IndexOffset.of(0),
                 Data.of(IndexGroup.of(adsAddress.getIndexGroup()).getBytes())
-            );
+            ))
+            .map(adsWriteRequest -> new PlcRequestContainer<>(new PlcProprietaryRequest<>(adsWriteRequest), new CompletableFuture<>()))
             // We don't need a response so we just supply a throw away future.
-            channel.writeAndFlush(new PlcRequestContainer<>(new PlcProprietaryRequest<>(adsWriteRequest), new CompletableFuture<>()));
-        }
+            .forEach(channel::writeAndFlush);
         super.close();
     }
 

-- 
To stop receiving notification emails like this one, please contact
sruehl@apache.org.