You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/04 18:31:29 UTC
[GitHub] [tvm] anwang2009 opened a new pull request #10171: Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
anwang2009 opened a new pull request #10171:
URL: https://github.com/apache/tvm/pull/10171
Reverts apache/tvm#10065.
After doing a sweep on nvidia t4 with 2000 autotvm trials, I'm seeing regressions across the board as compared to before this commit. We should revert and investigate why this is happening before we enable this change broadly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi edited a comment on pull request #10171: Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1030317195
I dont like reverting this. This will put us back to the wrong state and there is no guarentee that it will be restored later unless someone takes an action.
So instead of reverting this to workaround the immediate perf problem, can we pursue a more long term solution. Have you tried enabling alter layout? If this is cuda, the issue is most likely related to winograd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10171: Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1030317195
I dont like reverting this. This will put us back to the wrong state and there is no guarentee that it will be restored later unless someone takes an action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anwang2009 commented on pull request #10171: [DO NOT MERGE] Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
anwang2009 commented on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1036764415
Closing this. Sweeps show that the relay opt level 3 is the right approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anwang2009 commented on pull request #10171: Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
anwang2009 commented on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1030245730
cc @tkonolige @masahi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10171: Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1031914962
@anwang2009 can you open an issue for tracking and then maybe we will be amenable to merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anwang2009 closed pull request #10171: [DO NOT MERGE] Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
anwang2009 closed pull request #10171:
URL: https://github.com/apache/tvm/pull/10171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anwang2009 commented on pull request #10171: Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
anwang2009 commented on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1030372853
Yeah, we've tried enabling alter layout. It has similar results as shown. I'm seeing regressions on broadwell as well as nvidia tesla t4, but the regressions are more pronounced on the t4. Currently running a sweep to confirm if the problem was actually this PR or another one on the stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anwang2009 commented on pull request #10171: [DO NOT MERGE] Revert "[AUTOTVM] Use opt level 3 when extracting tasks"
Posted by GitBox <gi...@apache.org>.
anwang2009 commented on pull request #10171:
URL: https://github.com/apache/tvm/pull/10171#issuecomment-1031928464
Awaiting results of this sweep before further action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org