You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "omus (via GitHub)" <gi...@apache.org> on 2023/01/29 04:48:45 UTC
[GitHub] [arrow-julia] omus opened a new pull request, #385: Fix `ToArrow` when using an abstract `eltype` with all missing elements
omus opened a new pull request, #385:
URL: https://github.com/apache/arrow-julia/pull/385
Addresses an issue introduced in #371:
```julia
julia> ArrowTypes.ToArrow(Union{Missing, Array{Int}}[missing])
ERROR: MethodError: no method matching zero(::Type{Union{Missing, Array{Int64}}})
Closest candidates are:
zero(::Type{Union{Missing, T}}) where T at missing.jl:105
zero(::Union{Type{P}, P}) where P<:Dates.Period at ~/Development/Julia/aarch64/1.8/usr/share/julia/stdlib/v1.8/Dates/src/periods.jl:53
zero(::LinearAlgebra.Diagonal) at ~/Development/Julia/aarch64/1.8/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/special.jl:381
...
Stacktrace:
[1] default(T::Type)
@ ArrowTypes ~/.julia/dev/Arrow/src/ArrowTypes/src/ArrowTypes.jl:303
[2] ToArrow(x::Vector{Union{Missing, Array{Int64}}})
@ ArrowTypes ~/.julia/dev/Arrow/src/ArrowTypes/src/ArrowTypes.jl:353
[3] top-level scope
@ REPL[2]:1
```
This error can occur when `eltype` of the array is non-concrete and all of the elements in the array are `missing`.
The approach in #371 doesn't work well with abstract `eltype`s as it uses `ArrowTypes.default` (i.e. what instance would `ArrowTypes.default(Array{Int})` return?). So this PR restricts the solution from #371 to only concrete `eltype`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #385: Fix `ToArrow` when using an abstract `eltype` with all missing elements
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #385:
URL: https://github.com/apache/arrow-julia/pull/385#issuecomment-1407563645
# [Codecov](https://codecov.io/gh/apache/arrow-julia/pull/385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#385](https://codecov.io/gh/apache/arrow-julia/pull/385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3a29db) into [main](https://codecov.io/gh/apache/arrow-julia/commit/59a6a10dadf5c2a3228c079e78b354a31a3f7973?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59a6a10) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 87.48% 87.45% -0.04%
==========================================
Files 26 26
Lines 3221 3221
==========================================
- Hits 2818 2817 -1
- Misses 403 404 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-julia/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/ArrowTypes/test/tests.jl](https://codecov.io/gh/apache/arrow-julia/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL0Fycm93VHlwZXMvdGVzdC90ZXN0cy5qbA==) | `100.00% <ø> (ø)` | |
| [src/ArrowTypes/src/ArrowTypes.jl](https://codecov.io/gh/apache/arrow-julia/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL0Fycm93VHlwZXMvc3JjL0Fycm93VHlwZXMuamw=) | `90.00% <100.00%> (-0.67%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj merged pull request #385: Fix `ToArrow` when using an abstract `eltype` with all missing elements
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj merged PR #385:
URL: https://github.com/apache/arrow-julia/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org