You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/20 08:52:54 UTC
[GitHub] [netbeans-mavenutils-nb-repository-plugin] ebarboni commented on a
change in pull request #3: NETBEANSINFRA-12 remove libraries that have
maven coordinate sha1 checked
ebarboni commented on a change in pull request #3: NETBEANSINFRA-12 remove libraries that have maven coordinate sha1 checked
URL: https://github.com/apache/netbeans-mavenutils-nb-repository-plugin/pull/3#discussion_r395502945
##########
File path: src/main/java/org/apache/netbeans/nbm/repository/PopulateRepositoryMojo.java
##########
@@ -389,16 +389,21 @@ else if ( skipLocalInstall )
String version = forcedVersion == null ? examinator.getSpecVersion() : forcedVersion;
String group = groupIdPrefix + ( examinator.isOsgiBundle() ? GROUP_EXTERNAL : examinator.hasPublicPackages() ? GROUP_API : GROUP_IMPL );
Artifact art = createArtifact( artifact, version, group );
+ ModuleWrapper wr = new ModuleWrapper( artifact, version, group, examinator, module, false );
if ( examinator.isOsgiBundle() )
{
Dependency dep = findExternal( module );
- if ( dep != null )
+ if ( dep != null )
{
+
+ art = createArtifact( artifact, dep.getVersion(), dep.getGroupId() );
+ group = dep.getGroupId();
+ version = dep.getVersion();
+ wr = new ModuleWrapper( artifact, version, group, examinator, module , true );
// XXX use those coords instead of publishing this
// (for now all bundles are from Orbit, which does not publish to Central, or specially built)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists