You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/21 02:04:30 UTC

[GitHub] [calcite] danny0405 commented on issue #1517: [CALCITE-3426] Compensate validConstant type in RexLiteral

danny0405 commented on issue #1517: [CALCITE-3426] Compensate validConstant type in RexLiteral
URL: https://github.com/apache/calcite/pull/1517#issuecomment-544320893
 
 
   @xy2953396112 Can you fix Julian's review comments to add more positive/negative tests for the tool method ? Although it is only used for tests, more tests would make it more reliable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services