You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/04 18:47:39 UTC
[GitHub] [geode] thesteve0 opened a new pull request, #7550: Fixing bug with geode home determination
thesteve0 opened a new pull request, #7550:
URL: https://github.com/apache/geode/pull/7550
If you place the product_dir in a path with "bin" in, the old method would ruin the path. For example
`C:\Users\steve\bin\apache-geode-1.14.4\bin\`
would become
`C:\Users\steveapache-geode-1.14.4`
This implementation cuts off the last 4 letters of the bin directory to get to the installation location.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] thesteve0 commented on pull request #7550: Fixing bug with geode home determination
Posted by GitBox <gi...@apache.org>.
thesteve0 commented on PR #7550:
URL: https://github.com/apache/geode/pull/7550#issuecomment-1094402165
That concourse build failure does not look related to my change - how do I clear it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] thesteve0 commented on a diff in pull request #7550: Fixing bug with geode home determination
Posted by GitBox <gi...@apache.org>.
thesteve0 commented on code in PR #7550:
URL: https://github.com/apache/geode/pull/7550#discussion_r844118660
##########
geode-assembly/src/main/dist/bin/gfsh.bat:
##########
@@ -27,7 +27,7 @@ REM
setlocal enableextensions
set scriptdir=%~dp0
-set gf=%scriptdir:\bin\=%
+set gf=%scriptdir:~0,-4%
Review Comment:
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #7550: Fixing bug with geode home determination
Posted by GitBox <gi...@apache.org>.
kirklund commented on PR #7550:
URL: https://github.com/apache/geode/pull/7550#issuecomment-1097321017
> That concourse build failure does not look related to my change - how do I clear it?
@thesteve0 You can either use:
```
git commit --allow-empty-message -m "Trigger precheckin"
```
or if you have access to tanzu projects, you can trigger just precheckin for unit-test using:
```
https://cio.hdb.gemfire-ci.info/pr-tool
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a diff in pull request #7550: Fixing bug with geode home determination
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on code in PR #7550:
URL: https://github.com/apache/geode/pull/7550#discussion_r843999088
##########
geode-assembly/src/main/dist/bin/gfsh.bat:
##########
@@ -27,7 +27,7 @@ REM
setlocal enableextensions
set scriptdir=%~dp0
-set gf=%scriptdir:\bin\=%
+set gf=%scriptdir:~0,-4%
Review Comment:
Could you just add a short comment so anyone else, looking at this in the future, knows why `4` in particular. Maybe:
```
REM Remove last 4 chars corresponding to bin\
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] thesteve0 commented on pull request #7550: Fixing bug with geode home determination
Posted by GitBox <gi...@apache.org>.
thesteve0 commented on PR #7550:
URL: https://github.com/apache/geode/pull/7550#issuecomment-1102761563
> Have you investigated why the unit tests are failing?
There are 37 failures - all of them Java exceptions some related to Mockito.
I changed 1 line in a windows bat file.
This seems to be something wrong with the test harness since I did not touch Java code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] thesteve0 commented on pull request #7550: Fixing bug with geode home determination
Posted by GitBox <gi...@apache.org>.
thesteve0 commented on PR #7550:
URL: https://github.com/apache/geode/pull/7550#issuecomment-1090442279
Changes made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org