You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/08/01 23:14:12 UTC
[kudu-CR] Move clock-related classes to src/kudu/clock
Todd Lipcon has posted comments on this change.
Change subject: Move clock-related classes to src/kudu/clock
......................................................................
Patch Set 3:
(3 comments)
fixed tidy issues in modified code (some pre-existing that are getting re-flagged due to the rename)
http://gerrit.cloudera.org:8080/#/c/7519/3/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:
Line 58: class Clock;
> warning: no definition found for 'Clock', but a definition with the same na
Done
http://gerrit.cloudera.org:8080/#/c/7519/3/src/kudu/tablet/tablet_bootstrap-test.cc
File src/kudu/tablet/tablet_bootstrap-test.cc:
Line 58: using log::ReadableLogSegment;
> warning: using decl 'ReadableLogSegment' is unused [misc-unused-using-decls
Done
http://gerrit.cloudera.org:8080/#/c/7519/3/src/kudu/tablet/transactions/transaction_driver.h
File src/kudu/tablet/transactions/transaction_driver.h:
Line 24: #include "kudu/consensus/raft_consensus.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done
--
To view, visit http://gerrit.cloudera.org:8080/7519
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4f49be6944ec636387f0c9f5721355402e51fc2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes