[GitHub] [incubator-doris] morningman commented on a change in pull request #4345: [Bug][MemTracker] Cleanup the mem tracker's constructor to avoid wrong usage

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4345:
URL: https://github.com/apache/incubator-doris/pull/4345#discussion_r469306197



##########
File path: be/src/runtime/mem_tracker.h
##########
@@ -588,14 +579,18 @@ class PoolMemTrackerRegistry {
   /// with the process tracker as its parent. There is no explicit per-pool byte_limit
   /// set at any particular impalad, so newly created trackers will always have a limit
   /// of -1.
+  /// TODO(cmy): this method is not used for now. the memtracker returned from here is
+  ///            got from a shared_ptr in `pool_to_mem_trackers_`.
+  ///            I don't know why it need to return a raw pointer.
+  ///            If this method be further used, please notice that.

Review comment:
       Okay, since this function has not been used yet, I will change the return value to shared_ptr




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org