You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org> on 2007/02/01 13:39:05 UTC
[jira] Created: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Scope defined java serialiazation/deserialization of SDO
--------------------------------------------------------
Key: TUSCANY-1086
URL: https://issues.apache.org/jira/browse/TUSCANY-1086
Project: Tuscany
Issue Type: Improvement
Components: Java SDO Implementation
Affects Versions: Java-M2
Environment: All
Reporter: Hasan Muhammad
Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470391 ]
Frank Budinsky commented on TUSCANY-1086:
-----------------------------------------
Hasan,
Can you provide a patch with what you've done so far, and a JUnit that illustrates what's not working, so I can take a look at it.
Thanks,
Frank.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469427 ]
Hasan Muhammad commented on TUSCANY-1086:
-----------------------------------------
Frank,
Would you want the same for an ObjectOutputStream (i.e. scope defined ) ? I was wondering why would anyone want to have a scope on both, since if at all one wanted to use the same scope for serialization/deserializaton, then they would use the global scope.. But still, wanted to ask if you thought we needed a scope defined ObjectOutputStream as well ?
BTW, i am creating a new class called SDOObjectInputStream under org.apache.tuscany.sdo.util.resource, just a placeHolder for the scope. This would be returned by the create method.
Hasan
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469563 ]
Frank Budinsky commented on TUSCANY-1086:
-----------------------------------------
Hasan,
Thanks for doing this.
I would say that we don't strictly need a scoped output stream, becasue the objects being serialized know their scope (types). It's only during deserialize (input stream) that we need to provide it with the location of the types. That said, I do think it would still be good to be symetrical and add two methods to SDOUtil:
SDOUtil.createObjectInputStream(HelperContext scope);
and
SDOUtil.createObjectOutputStream(HelperContext scope);
The second could just return an ordinary ObjectOutputStream. (maybe in the future it might do something special??).
Frank.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471480 ]
Hasan Muhammad commented on TUSCANY-1086:
-----------------------------------------
I forgot to change the JUnit to use the ByteStream. Will do that and resubmit the testcase. One quick thing about the use of "commonj.sdo" in writeExternal. I created a simple testcase where i just create a DataObject under a URI say "my.com". When i use the xmlHelper.save() method, it will not work with the "commonj.sdo" string for the URI. It works either with null or the URI under which the dataObject was created.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, JavaSerializeDeserializeTestCase.java, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson updated TUSCANY-1086:
------------------------------------
Fix Version/s: (was: Java-SDO-Mx)
Java-SDO-M3
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-M3
>
> Attachments: Final_SerDeserialization.zip, JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, JavaSerializeDeserializeTestCase.java, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471487 ]
Frank Budinsky commented on TUSCANY-1086:
-----------------------------------------
The difference is that if you use "commonj.sdo" it should use the predefined global property defined in sdoModel.xsd:
<xsd:element name="dataObject" type="xsd:anyType"/>
Since the type is xsd:anyType, you should be able to set it to your DataObject. The question is why isn't that working?
The other cases will demand create a dummy global property, which works, but isn't what we want.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, JavaSerializeDeserializeTestCase.java, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Muhammad updated TUSCANY-1086:
------------------------------------
Attachment: JavaSerDeserialize_NewFiles_TestCase.zip
JavaSerDeserialization.patch
I have attached the following:
1. JavaSerDeserialization.patch: This is a patch file containing the changes i made to existing SDO code. This patch file has been created from the Tuscany/java directory.
2. JavaSerDeserialize_NewFiles_TestCase.zip: This zip file contains the two new classes (SDOObjectInputStream and SDOObjectOutputStream) and a JUnit Test case. This zip file has been created from the Tuscany/java directory. You can simply unzip it there, and the source files will be restored in the proper directory.
So far, when i directly serialize the DataObject, it works with the changes i have made. The method in the testcase to test this is testScopeDefinedSerializeDeserializeOfDataObject()
The deserialization when a DataGraph has been serialized fails because it cant find the type. Again this happens because for a DataGraph, it is delegated to the readExternal() of the EDataGraphExternalizable class, where currently i could not find a way to pass on the scope information and hence it cant find the type. The testcase method for this test is testScopeDefinedSerializeDeserializeOfDataGraph().
Although the class SDOObjectOutputStream is not neccessary for this, i included for total symmetry
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469846 ]
Hasan Muhammad commented on TUSCANY-1086:
-----------------------------------------
Frank,
Ok.. did the above. But when i a serialize just a DataObject directly instead of a DataGraph, while deserializing, in ResolvableImpl.readDataObject(), since it does not have a root, it goes to the else clause where, it now directly reads from the DataObject, which then gets delegated to the EDataGraphExternalizable.readExternal(). In this method, we are creating a new Resource wherein lies the problem. Since this Resource is being created without a scope. I assume it is taking the global scope.
Now, i can do the following:
Resource resource = resourceSet.createResource(URI.createURI("all.datagraph"));
if(objectInput instanceof SDOObjectInputStream){
TypeHelper typeHelper = ((SDOObjectInputStream)objectInput).getHelperContext().getTypeHelper();
}
I can get the extendenMetaData from typeHelper, but i am stuck after this, since DataObjectUtil has ta method configureXMLResource() which does configure the resource to the scope (extendedMetaData), but that is an XMLResource. I assume we cant always typecast Resource to XMLResource. So we need a similar method such as configureResource(), to set the scope for the resoource, so that we can call that in the readExternal() method above.
Do you agree ?
Hasan
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "ant elder (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ant elder updated TUSCANY-1086:
-------------------------------
Fix Version/s: Java-SDO-Mx
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Budinsky resolved TUSCANY-1086.
-------------------------------------
Resolution: Fixed
Thanks Hasan. Committed revision 507115.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: Final_SerDeserialization.zip, JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, JavaSerializeDeserializeTestCase.java, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Muhammad updated TUSCANY-1086:
------------------------------------
Attachment: NEW_JavaSerDeserialization.patch
Frank
I have attached a new patch file: NEW_JavaSerDeserialization.patch
This contains all the code changes i submitted in the previous patch plus the code change i made to DataGraphImpl. The change i made basically is to set the scope for the resource through the MAP option "EXTENDED_META_DATA" in the readExternal(). Now the DataGraph serialization/deserialization works as well.
Please let me know what you think of it
Hasan
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Muhammad updated TUSCANY-1086:
------------------------------------
Attachment: Final_SerDeserialization.zip
Frank,
I have attached the zip file Final_SerDeserialization.zip. You should delete all other attachments.
This zip file contains the following:
1. Final version of the patch
2. The two new class files ( SDOObjectInputStream And SDOObjectOutputStream)
3. The JavaSerDeserialization test case.
The zip file and the patch within it have been created from the tuscany/java directory.
I did change the initializeType() in the generated ModelFactoryImpl. I have also added a new step in the regen instructions. Please review.
Hasan
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: Final_SerDeserialization.zip, JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, JavaSerializeDeserializeTestCase.java, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Hasan Muhammad (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Muhammad updated TUSCANY-1086:
------------------------------------
Attachment: JavaSerializeDeserializeTestCase.java
Frank,
Yeah my bad. I realized the testcase was not structured. I have set it right. I have reattached it here. Please remove the first 2 attachments. The testcase, and the old patch.
I will look into why with "null" it is working.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, JavaSerializeDeserializeTestCase.java, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1086) Scope defined java
serialiazation/deserialization of SDO
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471448 ]
Frank Budinsky commented on TUSCANY-1086:
-----------------------------------------
Thanks for doing this Hasan.
In general it looks very good, with one exception. In HelperProviderImpl you changed this:
xmlHelper.save(dataObject, "commonj.sdo", "dataObject", gzipOutputStream);
to this:
xmlHelper.save(dataObject, null, "dataObject", gzipOutputStream);
I believe that "commonj.sdo" is right, and wonder why you changed it. I suspect that if it doesn't work, we should figure out why not, and fix that.
Also, can you please fix the JUnit to use a ByteStream instead of creating a dummy file ("temporaryFile") in the file system? The formatting (indentation) of the JUnit is also all messed up. Please remember that this is an open "source" project so the source code is part of the product and should be nice and polished.
Thanks,
Frank.
> Scope defined java serialiazation/deserialization of SDO
> --------------------------------------------------------
>
> Key: TUSCANY-1086
> URL: https://issues.apache.org/jira/browse/TUSCANY-1086
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-M2
> Environment: All
> Reporter: Hasan Muhammad
> Fix For: Java-SDO-Mx
>
> Attachments: JavaSerDeserialization.patch, JavaSerDeserialize_NewFiles_TestCase.zip, NEW_JavaSerDeserialization.patch
>
>
> Need to have a scope defined java serialization/deserialization of SDO's. Currently it can be done only in the Global/default scope. Have to fix this by using helperContext as the scope for creating ObjectInputStream and ObjectOutputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org