You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/11 12:26:27 UTC

[GitHub] [incubator-yunikorn-web] kingamarton commented on a change in pull request #39: YUNIKORN-214: Fix travis build failure in yunikorn-web

kingamarton commented on a change in pull request #39:
URL: https://github.com/apache/incubator-yunikorn-web/pull/39#discussion_r438744724



##########
File path: .travis.yml
##########
@@ -41,9 +41,10 @@ jobs:
         - yarn lint
     - stage: publish docker image
       install: skip
+      script: skip

Review comment:
       Why is this script phase skipped? I think we should not skip it. This will triggered by cron conditions, so by default it should be skipped on PR-s, but will run periodically on master branch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org