You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/03/12 08:51:09 UTC
[PR] CAMEL-23164: Create camel-ftp-common module for shared FTP/SFTP code [camel]
gnodet opened a new pull request, #21950:
URL: https://github.com/apache/camel/pull/21950
## Summary
- **Commit 1**: Create `camel-ftp-common` module with 14 shared classes moved from `camel-ftp` (RemoteFile*, FtpConstants, FtpUtils, SftpRemoteFile*, SftpDefaultMoveExistingFileStrategy). Delete 2 duplicate classes from `camel-mina-sftp`. Update dependency graph and BOMs.
- **Commit 2**: Extract `AbstractSftpConsumer` into `camel-ftp-common` with shared polling/directory traversal logic. Both `SftpConsumer` and `MinaSftpConsumer` become thin subclasses (~80 lines each vs ~350 before).
- **Commit 3**: Extract `BaseSftpConfiguration` into `camel-ftp-common` with ~20 shared SFTP config fields (known hosts, private key, server alive, chmod, compression, etc.). `SftpConfiguration` and `MinaSftpConfiguration` keep only implementation-specific fields.
## Test plan
- [x] `camel-ftp-common`, `camel-ftp`, and `camel-mina-sftp` build successfully
- [ ] Run `camel-ftp` unit tests: `mvn test -pl components/camel-ftp`
- [ ] Run `camel-mina-sftp` unit tests: `mvn test -pl components/camel-mina-sftp`
- [ ] Verify no regression in SFTP consumer behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23164: Create camel-ftp-common module for shared FTP/SFTP code [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #21950:
URL: https://github.com/apache/camel/pull/21950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23164: Create camel-ftp-common module for shared FTP/SFTP code [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21950:
URL: https://github.com/apache/camel/pull/21950#issuecomment-4045023828
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org