You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:16:12 UTC
[GitHub] [ignite] Mmuzaf opened a new pull request #7765: IGNITE-12937: Add pull request github template
Mmuzaf opened a new pull request #7765:
URL: https://github.com/apache/ignite/pull/7765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r421982600
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
+- [ ] The JIRA ticket has the _Patch Available_ state.
+- [ ] The pull request body describes changes that have been made.
+The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
+- [ ] The pull request title treated as the final commit message.
+The following pattern must be used: `IGNITE-12407: Java thin client. Cluster API support`
Review comment:
Subject should have imperative mood: `IGNITE-12407: Add Cluster API support to Java thin client`, or `IGNITE-12407: Java thin client - add Cluster API support`
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
+- [ ] The JIRA ticket has the _Patch Available_ state.
+- [ ] The pull request body describes changes that have been made.
+The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
+- [ ] The pull request title treated as the final commit message.
+The following pattern must be used: `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] A reviewer has been mentioned through the JIRA comments
+(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
+- [ ] The pull request has been checked by the Teamcity Bot and
+the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
+
+### Notes
+- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
+- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
+- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
+- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
+
+If you need any help, please email to dev@ignite.apache.org or asking anу advice on http://asf.slack.com _#ignite_ channel.
Review comment:
* `email to` -> `email` (it is a verb)
* `asking` -> `ask`
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
+- [ ] The JIRA ticket has the _Patch Available_ state.
+- [ ] The pull request body describes changes that have been made.
+The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
+- [ ] The pull request title treated as the final commit message.
Review comment:
`is treated`
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
Review comment:
`is attached`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r419078923
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
Review comment:
Associated how?
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] Commits have the following pattern
Review comment:
In my opinion, this should not be a requirement. We merge with squash, why waste time on intermediate commits? There can be hundreds of them with review fixes, test tweaks, and so on.
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
Review comment:
I think we should provide a detailed commit message guide on Ignite Wiki, and add a link here.
Lots of good guidance here: https://chris.beams.io/posts/git-commit/
PR title and description should be used for the final squashed commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r421714038
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
Review comment:
I've added `tread PR title as final commit message` to the checklist.
There is a link to the `How to Contribute` wiki page that exists below. We can mention other commit message requirements there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] samaitra commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
samaitra commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r418791786
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] Commits have the following pattern
+e.g. `IGNITE-12835: Thin client. Compute support added`
+- [ ] A reviewer has been asked for the review through the JIRA comments
+(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
+- [ ] The pull request has been checked by the Teamcity Bot and
+the `green visa` applied to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
Review comment:
Shall we consider using travis build results for PR requests? Since travis build is already part of PR request process and build results are already available in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r422028357
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
+- [ ] The JIRA ticket has the _Patch Available_ state.
+- [ ] The pull request body describes changes that have been made.
+The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
+- [ ] The pull request title treated as the final commit message.
+The following pattern must be used: `IGNITE-12407: Java thin client. Cluster API support`
Review comment:
Fixed.
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
+- [ ] The JIRA ticket has the _Patch Available_ state.
+- [ ] The pull request body describes changes that have been made.
+The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
+- [ ] The pull request title treated as the final commit message.
Review comment:
Fixed.
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r421714389
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
Review comment:
Fixed.
The weblink must exist on the PR in the JIRA ticket.
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] Commits have the following pattern
Review comment:
I've removed this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r422028320
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] There is a single JIRA ticket related to the pull request.
+- [ ] The web-link to the pull request attached to the JIRA ticket.
+- [ ] The JIRA ticket has the _Patch Available_ state.
+- [ ] The pull request body describes changes that have been made.
+The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
+- [ ] The pull request title treated as the final commit message.
+The following pattern must be used: `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] A reviewer has been mentioned through the JIRA comments
+(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
+- [ ] The pull request has been checked by the Teamcity Bot and
+the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
+
+### Notes
+- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
+- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
+- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
+- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
+
+If you need any help, please email to dev@ignite.apache.org or asking anу advice on http://asf.slack.com _#ignite_ channel.
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r418924331
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] Commits have the following pattern
+e.g. `IGNITE-12835: Thin client. Compute support added`
+- [ ] A reviewer has been asked for the review through the JIRA comments
+(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
+- [ ] The pull request has been checked by the Teamcity Bot and
+the `green visa` applied to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
Review comment:
Currently, travisci is just a helpful check for PR and the `greenvisa` still required. For most PRs it is necessary to have all CI passed successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org