You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/05/02 02:17:20 UTC
Review Request 58909: Added test helpers to tranlate to
ContainerConfig.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58909/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
This adds a helper that emulates the logic in the Agent's launch path.
Now that the Containerizer takes a ContainerConfig instead of
a TaskInfo/ExecutorInfo/Directory/SlaveID/User, tests that call
the containerizer directly will need to translate to
ContainerConfig.
Diffs
-----
src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
Diff: https://reviews.apache.org/r/58909/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 58909: Added test helpers to tranlate to
ContainerConfig.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58909/#review174661
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 2, 2017, 2:17 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58909/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 2:17 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a helper that emulates the logic in the Agent's launch path.
> Now that the Containerizer takes a ContainerConfig instead of
> a TaskInfo/ExecutorInfo/Directory/SlaveID/User, tests that call
> the containerizer directly will need to translate to
> ContainerConfig.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
>
>
> Diff: https://reviews.apache.org/r/58909/diff/1/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>