You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/10/29 11:13:16 UTC

[GitHub] [incubator-echarts] pissang commented on a change in pull request #11504: fix bug #11000 Type of legend form scroll to plain

pissang commented on a change in pull request #11504: fix bug #11000 Type of legend form scroll to plain
URL: https://github.com/apache/incubator-echarts/pull/11504#discussion_r340014939
 
 

 ##########
 File path: src/model/Global.js
 ##########
 @@ -212,7 +212,7 @@ var GlobalModel = Model.extend({
                         mainType, resultItem.keyInfo.subType, true
                     );
 
-                    if (componentModel && componentModel instanceof ComponentModelClass) {
+                    if (componentModel && componentModel.constructor === ComponentModelClass.constructor) {
 
 Review comment:
   I think this should be `componentModel.constructor === ComponentModelClass`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org