You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2005/06/02 00:05:30 UTC
DO NOT REPLY [Bug 34849] -
Expression Language Field Validator
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34849>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34849
------- Additional Comments From Joe@Germuska.com 2005-06-02 00:05 -------
(In reply to comment #19)
> Yes, sorry I missed that - but I'm now wondering whats the point of creating
> this mock PageContext? I can see the advantage of searching scopes, but not in
> setting and removing attributes. Could the pageContext var not just be a Map
> implementation that includes the scope searching?
I'd like to get some more feedback on this issue. At this time, I feel that
using the PageContext implementation provides clarity to people familiar with
writing JSTL expressions in that context; also, the actual ActionContext isn't
available for the expression evaluation as it is now, since it isn't passed into
the validation process -- so if we didn't use this PageContext implementation,
we'd have to do something else comparably artificial.
On the other hand, maybe something comparably artificial is fine, especially if
it's more "struts like" in other ways. I'll wait for a few strong opinions, but
I'm getting closer to moving ahead like this:
1) rename ELValidator to ExpressionValidator
2) rename configuration in default validator-rules.xml to be "expression", not "EL"
3) rename var name from "EL" to "test"
4) eliminate collections and JSTL dependencies with private inner classes as
described elsewhere in this issue ticket
5) eliminate direct commons-lang dependency by using dynamic instantiation and
warning instead of erroring if lang is not present. (We'd use the Thread's
context classloader or the ExpressionValidator's classloader instead of
Class.forName, of course)
6) introduce a direct dependency on commons-jexl 1.0 to struts-core.
looking forward to getting more feedback.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org