You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2017/10/18 23:19:27 UTC
[sling-org-apache-sling-commons-metrics] 39/44: SLING-7028 - remove
assumption that histograms are durations
This is an automated email from the ASF dual-hosted git repository.
rombert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-metrics.git
commit 280f1bf811285c5b2410da97fbba9cca8a09a65f
Author: Justin Edelson <ju...@apache.org>
AuthorDate: Mon Aug 7 13:30:02 2017 +0000
SLING-7028 - remove assumption that histograms are durations
git-svn-id: https://svn.apache.org/repos/asf/sling/trunk@1804333 13f79535-47bb-0310-9956-ffa450edef68
---
.../metrics/internal/MetricWebConsolePlugin.java | 26 +++++++++-------------
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/src/main/java/org/apache/sling/commons/metrics/internal/MetricWebConsolePlugin.java b/src/main/java/org/apache/sling/commons/metrics/internal/MetricWebConsolePlugin.java
index 6b8e8c1..ea9bfec 100644
--- a/src/main/java/org/apache/sling/commons/metrics/internal/MetricWebConsolePlugin.java
+++ b/src/main/java/org/apache/sling/commons/metrics/internal/MetricWebConsolePlugin.java
@@ -314,7 +314,6 @@ public class MetricWebConsolePlugin extends HttpServlet implements
pw.println("<th class='header'>98%</th>");
pw.println("<th class='header'>99%</th>");
pw.println("<th class='header'>999%</th>");
- pw.println("<th>Duration Unit</th>");
pw.println("</tr>");
pw.println("</thead>");
pw.println("<tbody>");
@@ -325,25 +324,22 @@ public class MetricWebConsolePlugin extends HttpServlet implements
Snapshot s = h.getSnapshot();
String name = e.getKey();
- double durationFactor = 1.0 / timeUnit.durationFor(name).toNanos(1);
- String durationUnit = timeUnit.durationFor(name).toString().toLowerCase(Locale.US);
pw.printf("<tr class='%s ui-state-default'>%n", rowClass);
pw.printf("<td>%s</td>", name);
pw.printf("<td>%d</td>", h.getCount());
- pw.printf("<td>%f</td>", s.getMedian() * durationFactor);
- pw.printf("<td>%f</td>", s.getMin() * durationFactor);
- pw.printf("<td>%f</td>", s.getMax() * durationFactor);
- pw.printf("<td>%f</td>", s.getMean() * durationFactor);
- pw.printf("<td>%f</td>", s.getStdDev() * durationFactor);
+ pw.printf("<td>%f</td>", s.getMedian());
+ pw.printf("<td>%d</td>", s.getMin());
+ pw.printf("<td>%d</td>", s.getMax());
+ pw.printf("<td>%f</td>", s.getMean());
+ pw.printf("<td>%f</td>", s.getStdDev());
+
+ pw.printf("<td>%f</td>", s.get75thPercentile());
+ pw.printf("<td>%f</td>", s.get95thPercentile());
+ pw.printf("<td>%f</td>", s.get98thPercentile());
+ pw.printf("<td>%f</td>", s.get99thPercentile());
+ pw.printf("<td>%f</td>", s.get999thPercentile());
- pw.printf("<td>%f</td>", s.get75thPercentile() * durationFactor);
- pw.printf("<td>%f</td>", s.get95thPercentile() * durationFactor);
- pw.printf("<td>%f</td>", s.get98thPercentile() * durationFactor);
- pw.printf("<td>%f</td>", s.get99thPercentile() * durationFactor);
- pw.printf("<td>%f</td>", s.get999thPercentile() * durationFactor);
-
- pw.printf("<td>%s</td>", durationUnit);
pw.println("</tr>");
rowClass = "odd".equals(rowClass) ? "even" : "odd";
--
To stop receiving notification emails like this one, please contact
"commits@sling.apache.org" <co...@sling.apache.org>.