You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by rk...@apache.org on 2018/05/28 08:30:34 UTC
zeppelin git commit: ZEPPELIN-3496 Notebook title not visible in
simple and report mode
Repository: zeppelin
Updated Branches:
refs/heads/master c41ba77ff -> 2a9663600
ZEPPELIN-3496 Notebook title not visible in simple and report mode
Notebook title not visible in simple and report mode
- fix title visibility
- fix title alignment
Bug Fix
https://issues.apache.org/jira/browse/ZEPPELIN-3496
manually switch views between default, simple and report
**Simple view before**
<img width="1020" alt="simple-view-before" src="https://user-images.githubusercontent.com/2031306/40469731-1b873c7e-5f4f-11e8-8bba-5958e963b53f.png">
**Simple view hover before** (left alignment is off)
<img width="1029" alt="simple-view-hover-before" src="https://user-images.githubusercontent.com/2031306/40469730-1b4254c4-5f4f-11e8-9166-c2da6b0cc130.png">
**Simple view after**
<img width="1009" alt="simple-view-after" src="https://user-images.githubusercontent.com/2031306/40469812-4b3b6b70-5f4f-11e8-87e2-474de25372d8.png">
**Simple view hover after**
<img width="943" alt="simple-view-hover-after" src="https://user-images.githubusercontent.com/2031306/40469811-4b0a04fe-5f4f-11e8-8d2a-5435f722afd1.png">
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Renjith Kamath <rk...@apache.org>
Closes #2983 from r-kamath/ZEPPELIN-3496 and squashes the following commits:
4dd6286b2 [Renjith Kamath] ZEPPELIN-3496 Notebook title not visible in simple and report mode
Change-Id: I101f116ae2d1bcdc1820d32eeb05c9cfdd7864a0
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/2a966360
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/2a966360
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/2a966360
Branch: refs/heads/master
Commit: 2a966360026e7b4bb8c19168bbd0a85b0a7a9752
Parents: c41ba77
Author: Renjith Kamath <rk...@apache.org>
Authored: Thu May 24 12:31:18 2018 +0530
Committer: Renjith Kamath <rk...@apache.org>
Committed: Mon May 28 14:00:26 2018 +0530
----------------------------------------------------------------------
zeppelin-web/src/app/notebook/notebook-actionBar.html | 5 +++--
zeppelin-web/src/assets/styles/looknfeel/report.css | 4 ++++
zeppelin-web/src/assets/styles/looknfeel/simple.css | 4 ++++
3 files changed, 11 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2a966360/zeppelin-web/src/app/notebook/notebook-actionBar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook-actionBar.html b/zeppelin-web/src/app/notebook/notebook-actionBar.html
index 78ca77e..2229223 100644
--- a/zeppelin-web/src/app/notebook/notebook-actionBar.html
+++ b/zeppelin-web/src/app/notebook/notebook-actionBar.html
@@ -17,10 +17,11 @@ limitations under the License.
<div style="float: left; width: auto; max-width: 40%"
ng-controller="ElasticInputCtrl as input">
<input type="text" pu-elastic-input class="form-control2" placeholder="New name"
- style="min-width: 0px; max-width: 85%; margin-left: 2em;"
+ style="min-width: 0px; max-width: 85%;"
ng-if="input.showEditor" ng-model="input.value" ng-escape="input.showEditor = false" focus-if="input.showEditor"
ng-blur="updateNoteName(input.value);input.showEditor = false;" ng-enter="updateNoteName(input.value);input.showEditor = false;" />
- <p class="form-control-static2 reverse-ellipsis ellipsis"
+ <p class="form-control-static2"
+ ng-class="{'reverse-ellipsis ellipsis':noteName(note).length > 45}"
tooltip-placement="bottom"
uib-tooltip={{noteName(note)}}
ng-click="input.showEditor = !revisionView; input.value = note.name"
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2a966360/zeppelin-web/src/assets/styles/looknfeel/report.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/assets/styles/looknfeel/report.css b/zeppelin-web/src/assets/styles/looknfeel/report.css
index 8c850ef..11fca67 100644
--- a/zeppelin-web/src/assets/styles/looknfeel/report.css
+++ b/zeppelin-web/src/assets/styles/looknfeel/report.css
@@ -58,6 +58,10 @@ body {
visibility: hidden;
}
+.noteAction .form-control-static2 > span {
+ visibility: visible;
+}
+
.noteAction:hover span,
.noteAction:hover button,
.noteAction:hover form {
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/2a966360/zeppelin-web/src/assets/styles/looknfeel/simple.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/assets/styles/looknfeel/simple.css b/zeppelin-web/src/assets/styles/looknfeel/simple.css
index 0078306..55a6484 100644
--- a/zeppelin-web/src/assets/styles/looknfeel/simple.css
+++ b/zeppelin-web/src/assets/styles/looknfeel/simple.css
@@ -89,6 +89,10 @@ body {
visibility: hidden;
}
+.noteAction .form-control-static2 > span {
+ visibility: visible;
+}
+
.noteAction:hover span,
.noteAction:hover button,
.noteAction:hover form {