You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/21 10:11:26 UTC
[GitHub] [hbase] infraio commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …
infraio commented on a change in pull request #2430:
URL: https://github.com/apache/hbase/pull/2430#discussion_r491929256
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
##########
@@ -63,7 +121,7 @@ protected synchronized void disconnect() {
* A private method used to re-establish a zookeeper session with a peer cluster.
* @param ke
*/
- protected void reconnect(KeeperException ke) {
+ private void reconnect(KeeperException ke) {
Review comment:
Now only ReplicationEndpoint is IA.LimitedPrivate. So if one user want to use these logics, it is better to copied these code to their implementation.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java
##########
@@ -63,7 +121,7 @@ protected synchronized void disconnect() {
* A private method used to re-establish a zookeeper session with a peer cluster.
* @param ke
*/
- protected void reconnect(KeeperException ke) {
+ private void reconnect(KeeperException ke) {
Review comment:
Now only ReplicationEndpoint is IA.LimitedPrivate. So if one user want to use these logics, it is better to copy these code to their implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org