[jira] [Comment Edited] (TS-2842) Can't set SPDY inactivity timeout with traffic_line

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011478#comment-14011478 ] 

Leif Hedstrom edited comment on TS-2842 at 5/28/14 7:27 PM:
------------------------------------------------------------

Agreed. I'd personally prefer not to introduce that new struct, particularly not with that naming (they are not overridable). The normal way is to simply add all those new configurations to the appropriate (existing) struct, and register the update callback for all of them (individually).

Also, if the intent is to make these overridable, they should be members of the existing overridable struct. And then also be added to InkAPI.cc, ts/ts.h as well as InkAPITest.cc.


was (Author: zwoop):
Agreed. I'd personally prefer not to introduce that new struct, particularly not with that naming (they are not overridable). The normal way is to simply add all those new configurations to the appropriate (existing) struct, and register the update callback for all of them (individually).

> Can't set SPDY inactivity timeout with traffic_line
> ---------------------------------------------------
>
>                 Key: TS-2842
>                 URL: https://issues.apache.org/jira/browse/TS-2842
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: SPDY, Tools
>            Reporter: Bryan Call
>            Assignee: Bryan Call
>             Fix For: 5.0.0
>
>         Attachments: ts2842.diff
>
>
> Works for other configuration options:
> {code}
> [bcall@l10 trafficserver]$ sudo traffic_line -s proxy.config.http.keep_alive_no_activity_timeout_in -v 61
> [bcall@l10 trafficserver]$ sudo traffic_line -r proxy.config.http.keep_alive_no_activity_timeout_in
> 61
> {code}
> Doesn't work for the SPDY inactivity:
> {code}
> [bcall@l10 trafficserver]$ sudo traffic_line -s proxy.config.spdy.no_activity_timeout_in -v 31
> traffic_line: Please correct your variable name and|or value
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)