You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/16 18:24:54 UTC
[GitHub] [maven] oopexpert opened a new pull request #327: [Refactoring]
"copy" in object scope rather in class scope
oopexpert opened a new pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327
This refactoring refers to a more intuitive API approach.
The interface "MavenExecutionRequest" now provides an object scope method to copy itself. This has to be implemented by each sub type of "MavenExecutionRequest". Neverteless: I only found the class "DefaultMavenExecutionRequest" implementing the interface.
1. Providing an object scope copy method makes the usage less verbose.
2. As the copy method is defined abstract: the MavenCli class got rid of the concrete class "DefaultMavenExecutionRequest" dependency
The static copy method has been declared deprecated and can be made private in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on issue #327: [Refactoring] "copy" in
object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
oopexpert commented on issue #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#issuecomment-586751478
>
>
> Please create a JIRA issue for this.
And which project in JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379926893
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -763,7 +762,7 @@ protected void configure()
configure( cliRequest );
- MavenExecutionRequest request = DefaultMavenExecutionRequest.copy( cliRequest.request );
+ MavenExecutionRequest request = cliRequest.request.copy();
Review comment:
This indent seems to be unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379938222
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
Shall I rebase my commits with JIRA associating comments and provide a new pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379939039
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
Which project in JIRA issue? I am confused of that many projects available...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379929701
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
3.7.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379928208
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
Please add a since tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379938654
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
Not necessary, just force push to this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379929355
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
I thought about that... But which version might it be? ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #327:
[MNG-6865] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #327: [MNG-6865] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379939322
##########
File path: maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java
##########
@@ -442,4 +442,10 @@
* @since 3.3.0
*/
Map<String, Object> getData();
+
+ /**
+ * @return a copy of this
+ */
Review comment:
https://issues.apache.org/jira/projects/MNG
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on a change in pull request #327:
[Refactoring] "copy" in object scope rather in class scope
Posted by GitBox <gi...@apache.org>.
oopexpert commented on a change in pull request #327: [Refactoring] "copy" in object scope rather in class scope
URL: https://github.com/apache/maven/pull/327#discussion_r379928145
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -763,7 +762,7 @@ protected void configure()
configure( cliRequest );
- MavenExecutionRequest request = DefaultMavenExecutionRequest.copy( cliRequest.request );
+ MavenExecutionRequest request = cliRequest.request.copy();
Review comment:
adapted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services