You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "echauchot (via GitHub)" <gi...@apache.org> on 2023/04/19 13:24:10 UTC

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #12: [FLINK-31807] Include all test code in architecture tests

echauchot commented on code in PR #12:
URL: https://github.com/apache/flink-connector-cassandra/pull/12#discussion_r1171293507


##########
flink-connector-cassandra/archunit-violations/dc1ba6f4-3d84-498c-a085-e02ba5936201:
##########
@@ -1,6 +1,12 @@
-org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase does not satisfy: only one of the following predicates match:\
+org.apache.flink.connector.cassandra.source.CassandraSourceITCase does not satisfy: only one of the following predicates match:\

Review Comment:
   I approved [the related PR](https://github.com/apache/flink/pull/22399)



##########
flink-connector-cassandra/src/test/java/org/apache/flink/architecture/TestCodeArchitectureTest.java:
##########
@@ -29,7 +29,9 @@
 @AnalyzeClasses(
         packages = {
             "org.apache.flink.batch.connectors.cassandra",
-            "org.apache.flink.streaming.connectors.cassandra"

Review Comment:
   I checked: all the different packages are there.



##########
flink-connector-cassandra/archunit-violations/dc1ba6f4-3d84-498c-a085-e02ba5936201:
##########
@@ -1,6 +1,12 @@
-org.apache.flink.streaming.connectors.cassandra.CassandraConnectorITCase does not satisfy: only one of the following predicates match:\
+org.apache.flink.connector.cassandra.source.CassandraSourceITCase does not satisfy: only one of the following predicates match:\

Review Comment:
   > [FLINK-31804](https://issues.apache.org/jira/browse/FLINK-31804) will resolve this "violation".
   
   Once the other PR is merged and the cassandra connector uses the new rule, only `CassandraSourceITCase` "violation" will be removed. `CassandraConnectorITCase` "violation" will remain as this class does not use MiniCluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org