You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/04/07 18:14:02 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #23624: fix(docker): optimize docker build by better utilizing build cache
sebastianliebscher opened a new pull request, #23624:
URL: https://github.com/apache/superset/pull/23624
### SUMMARY
The `chown -R` command causes the `/app` directory contents from previous `COPY`'s to be copied up to the current layer. This results in additional redundant image size.
By using `COPY --chown` we can reduce the image size by ~130 MB.
Also
- remove duplicate `COPY setup.py MANIFEST.in README.md /app/`
- adjust indentation
- fix `pip install` option from `--no-cache` to `--no-cache-dir`
### TESTING INSTRUCTIONS
`docker build -t superset --no-cache .`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23624: fix(docker): optimize docker build by better utilizing build cache
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23624:
URL: https://github.com/apache/superset/pull/23624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23624: fix(docker): optimize docker build by better utilizing build cache
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23624:
URL: https://github.com/apache/superset/pull/23624#issuecomment-1503840928
Hi @villebro @dpgaspar! Would you like to review this interesting PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org