You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/02/06 22:49:56 UTC

svn commit: r1657974 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common: PDPageLabelRange.java PDPageLabels.java

Author: tilman
Date: Fri Feb  6 21:49:55 2015
New Revision: 1657974

URL: http://svn.apache.org/r1657974
Log:
PDFBOX-2576: add constant; use interface instead of implementation class; make fields final

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabelRange.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabelRange.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabelRange.java?rev=1657974&r1=1657973&r2=1657974&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabelRange.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabelRange.java Fri Feb  6 21:49:55 2015
@@ -36,9 +36,9 @@ public class PDPageLabelRange implements
     private COSDictionary root;
 
     // Page label dictonary (PDF32000-1:2008 Section 12.4.2, Table 159)
-    private static final COSName KEY_START = COSName.getPDFName("St");
+    private static final COSName KEY_START = COSName.ST;
     private static final COSName KEY_PREFIX = COSName.P;
-    private static final COSName KEY_STYLE = COSName.getPDFName("S");
+    private static final COSName KEY_STYLE = COSName.S;
 
     // Style entry values (PDF32000-1:2008 Section 12.4.2, Table 159)
 

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java?rev=1657974&r1=1657973&r2=1657974&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java Fri Feb  6 21:49:55 2015
@@ -43,7 +43,7 @@ import org.apache.pdfbox.pdmodel.PDDocum
 public class PDPageLabels implements COSObjectable
 {
 
-    private SortedMap<Integer, PDPageLabelRange> labels;
+    private Map<Integer, PDPageLabelRange> labels;
 
     private PDDocument doc;
 
@@ -287,8 +287,8 @@ public class PDPageLabels implements COS
      */
     private static class LabelGenerator implements Iterator<String>
     {
-        private PDPageLabelRange labelInfo;
-        private int numPages;
+        private final PDPageLabelRange labelInfo;
+        private final int numPages;
         private int currentPage;
 
         LabelGenerator(PDPageLabelRange label, int pages)